-
Notifications
You must be signed in to change notification settings - Fork 524
WWSTCERT-10247 Add pad19 dimmer driver #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WWSTCERT-10247 Add pad19 dimmer driver #2762
Conversation
A profile of PAD19 (dimmer switch).
The edge driver of PAD19 for WWST certification.
greens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just be adding a sub-driver to the base driver, not adding a new driver in a folder under the base driver.
Here's an example from another partner of how this looks: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/2371/changes
|
Dear SmartThings Team,
Thank you for your review comments and guidance regarding our pull request.
We would like to seek clarification on the driver structure requirement.
Based on the feedback, it appears that we are expected to add our
implementation as a sub-driver under the existing base driver rather
than creating a separate driver.
Our original intention was to develop and maintain a dedicated Philio
Edge Driver under our company name. Could you please confirm whether,
for WWST certification submissions within the SmartThingsCommunity
repository, all device support must be integrated into the existing base
drivers as sub-drivers?
If maintaining a standalone Philio driver is not supported within this
repository, we would appreciate your advice on the recommended approach
for vendors who wish to publish and manage their own branded drivers
while still pursuing WWST certification.
Thank you for your clarification and support.
Best regards,
Jerry Yang
Steven Green 於 2026/2/11 上午 07:30 寫道:
***@***.**** requested changes on this pull request.
You should just be adding a sub-driver to the base driver, not adding
a new driver in a folder under the base driver.
Here's an example from another partner of how this looks:
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/2371/changes
—
Reply to this email directly, view it on GitHub
<#2762 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSU2RL3K7R3XKEEN5SPUQ34LJSY7AVCNFSM6AAAAACUGCC4JSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOOBSGE2DSNZVG4>.
You are receiving this because you modified the open/close
state.Message ID:
***@***.***>
--
楊嘉慶
軟體設計部 經理
leaf
新北市新莊區中正路651之1號7樓
Tel: +886-2-2908-8952 ext:304
Fax: +886-2-2908-8652
http://philio-tech.com
leaf
|
|
@JerryYang01 based on the code you've included in this PR, it's not clear that you would gain anything by having a separate driver. Your device seems to behave according to the Z-Wave spec, and would be well covered by our base z-wave switch driver. Our base drivers are written so that most devices can integrate with just the addition of the device's fingerprint to the But also, if your intent was to have an all new driver, you would want it to be alongside |
|
Hi Steven :
Thank you for the detailed explanation and guidance. I understand your
point regarding the use of the base Z-Wave switch driver and the
benefits it provides in terms of maintainability and integration.
I’ll review the implementation and try modifying it by adding the device
fingerprint to the existing base driver instead of creating a separate
one. If I run into any issues or have further questions, I’ll follow up.
Thanks again for the clarification.
Best regards,
Jerry Yang
Steven Green 於 2026/2/12 上午 07:39 寫道:
@JerryYang01 <https://github.com/JerryYang01> based on the code you've
included in this PR, it's not clear that you would gain anything by
having a separate driver. Your device seems to behave according to the
Z-Wave spec, and would be well covered by our base z-wave switch
driver. Our base drivers are written so that most devices can
integrate with just the addition of the device's fingerprint to the
|fingerprints.yml| file. This is for our own east of maintainability,
but also to make it easy for partners such as yourselves.
But also, if your intent was to have an all new driver, you would want
it to be /alongside/ |zwave-switch| in the directory structure, not
under it.
--
楊嘉慶
軟體設計部 經理
leaf
新北市新莊區中正路651之1號7樓
Tel: +886-2-2908-8952 ext:304
Fax: +886-2-2908-8652
http://philio-tech.com
leaf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Steven's feedback regarding the driver structure. Also be sure to remove the print() statements from this file.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests