Remove dependency on Half#21
Conversation
|
@SomeRandomiOSDev what's it going to take to get this PR accepted? The failed "@codacy-production With these changes, the library passes all tests on Windows and I would submit CI actions to test there. |
|
Argh, for my purposes this is not a fully-complete solution because I wonder if support for CBOR serializing 16-bit floats really needs to be built into the core of this library, or if it could be added as an extension the way we normally would with any user-defined types? |
|
@christophhagen I took a first cut at making it work on x64 macs, but it's clear that some of the old logic needs to be restored because the build is failing. The CI job passes for some reason, which also needs to be corrected in the workflow file. |
|
@christophhagen OK, fixing it for x64 macs was easy: christophhagen#1 |
|
@christophhagen And here is the PR that ensures failures in CI are actually reported. |
|
@christophhagen I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly |
|
Closing the PR due to #27. |
Description
This PR removes the dependency on
Half, which is currently used to provide a half-precision floating point type.Float16was introduced with Swift 5.3, so the dependency is no longer needed.Checklist
Ensure that your
pull requesthas followed all the steps below:Proposed changes
The main changes are:
Float16type insteadMinor changes are:
if-elsestatementsAdditional Info
The dependency on
Float16requires higher minimum deployment targets on all platforms:9.0->14.010.10->11.09.0->14.02.0->7.0For systems with swift version lower than
5.3, the dependency on Half is still needed. In this case thetypealias Float16 = Halfis included. The package descriptions for4.2and5.0still include the dependency. The correct compilation on older platforms is untested.