SONARJAVA-4960 False positive for S1854 by rombirli · Pull Request #5378 · SonarSource/sonar-java

rombirli · 2025-12-17T14:30:51Z

hashicorp-vault-sonar-prod · 2025-12-17T14:31:07Z

github-actions · 2025-12-27T03:03:04Z

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

java-checks/src/test/java/org/sonar/java/checks/DeadStoreCheckTest.java

java-frontend/src/main/java/org/sonar/java/model/Symbols.java

...-checks-test-sources/default/src/main/files/non-compiling/checks/UnusedVariablesFPCheck.java

java-frontend/src/test/java/org/sonar/java/model/SymbolsTest.java

sonarqube-next · 2026-01-08T10:26:29Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

github-actions · 2026-01-16T03:07:55Z

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

java-frontend/src/main/java/org/sonar/java/model/Symbols.java

java-checks/src/test/java/org/sonar/java/checks/DeadStoreCheckTest.java

- https://community.sonarsource.com/t/false-positive-for-s1854-unused-assignments-should-be-removed/114110/10

rombirli · 2026-01-22T07:12:46Z

Addressed both issues in d78ed6b

sonarqube-next · 2026-01-22T07:24:22Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

github-actions · 2026-01-30T03:18:56Z

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

tomasz-tylenda-sonarsource · 2026-01-30T09:56:00Z

Is this ready for re-review?

rombirli · 2026-02-02T10:48:24Z

Is this ready for re-review?

Yes it is

tomasz-tylenda-sonarsource

Let's use dogfooding on peachee to test this PR. If you haven't used it before, it's a good thing to learn. We can talk about it offline.

tomasz-tylenda-sonarsource · 2026-02-04T16:42:35Z

java-frontend/src/test/java/org/sonar/java/model/SymbolsTest.java

    assertThat(unknownSymbol.isTypeSymbol()).isFalse();
    assertThat(unknownSymbol.isVariableSymbol()).isFalse();
-    assertThat(unknownSymbol.isMethodSymbol()).isFalse();
+    assertThat(unknownSymbol.isMethodSymbol()).isEqualTo(unknownSymbol instanceof Symbols.UnknownMethodSymbol);


We should not have logic in tests. Each test that calls assertCommonProperties should have an assertion with a constant, either true or false. After all, if this property changes, it is not a common property.

Reference: https://testing.googleblog.com/2014/07/testing-on-toilet-dont-put-logic-in.html

rombirli force-pushed the rombirli/S1854-false-positive branch from 19d09dc to 947f918 Compare December 18, 2025 08:39

rombirli marked this pull request as ready for review December 19, 2025 13:41

github-actions bot added the stale label Dec 27, 2025

github-actions bot closed this Jan 4, 2026

rombirli reopened this Jan 5, 2026

rombirli requested a review from a team January 5, 2026 07:40

github-actions bot removed the stale label Jan 6, 2026

rombirli requested a review from tomasz-tylenda-sonarsource January 7, 2026 15:07

tomasz-tylenda-sonarsource reviewed Jan 7, 2026

View reviewed changes

github-actions bot added the stale label Jan 16, 2026

rombirli removed the stale label Jan 19, 2026

rombirli requested a review from tomasz-tylenda-sonarsource January 19, 2026 08:18

tomasz-tylenda-sonarsource reviewed Jan 21, 2026

View reviewed changes

java-frontend/src/main/java/org/sonar/java/model/Symbols.java Show resolved Hide resolved

java-checks/src/test/java/org/sonar/java/checks/DeadStoreCheckTest.java Outdated Show resolved Hide resolved

rombirli added 7 commits January 22, 2026 08:03

Draft of "False positive for S1854 Solution"

fb4e522

- https://community.sonarsource.com/t/false-positive-for-s1854-unused-assignments-should-be-removed/114110/10

Moved non-compiling java file to non-compiling/checks

3da6e27

Fix autoscan

b78deef

Fix broken semantic tests

caaea40

Fix QG

36cc643

Address Tomasz' review comments, tests refactoring

ac1179b

Rollback incorrect fix in SymbolsTest.java

b23c2de

rombirli force-pushed the rombirli/S1854-false-positive branch from eb0e8ef to b23c2de Compare January 22, 2026 07:03

Address Tomasz' review : fix tests

d78ed6b

github-actions bot added the stale label Jan 30, 2026

github-actions bot removed the stale label Jan 31, 2026

rombirli requested a review from tomasz-tylenda-sonarsource February 2, 2026 10:48

tomasz-tylenda-sonarsource reviewed Feb 4, 2026

View reviewed changes

Conversation

rombirli commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hashicorp-vault-sonar-prod bot commented Dec 17, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqube-next bot commented Jan 8, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

rombirli commented Jan 22, 2026

Uh oh!

sonarqube-next bot commented Jan 22, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

tomasz-tylenda-sonarsource commented Jan 30, 2026

Uh oh!

rombirli commented Feb 2, 2026

Uh oh!

tomasz-tylenda-sonarsource left a comment

Choose a reason for hiding this comment

Uh oh!

tomasz-tylenda-sonarsource Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rombirli commented Dec 17, 2025 •

edited

Loading

hashicorp-vault-sonar-prod bot commented Dec 17, 2025 •

edited by atlassian bot

Loading