-
Notifications
You must be signed in to change notification settings - Fork 0
Support Ruby 4.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Support Ruby 4.0 #10
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fea4657
Update Ruby and Rails versions in main.yml for compatibility with Rub…
Syati cebe082
Adjust RuboCop configuration to remove space before Metrics/MethodLen…
Syati e484a82
Update Ruby version to 4.0.0 and adjust compatibility in main.yml and…
Syati 62259df
Add RBS configuration for missing type annotations and enable rbs_inl…
Syati d10151d
Enable RBS inline for type annotations across multiple files
Syati 402bab5
Refactor RuboCop and RBS configuration for Ruby 3.3+ support
Syati a108778
Update type annotations in dummy model classes to return String
Syati d629feb
Refactor RuboCop configuration to support RBS Inline and Ruby version…
Syati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # RuboCop configuration for Ruby 3.3+ with RBS Inline support | ||
| inherit_from: .rubocop.yml | ||
|
|
||
| plugins: | ||
| - rubocop-rbs_inline | ||
|
|
||
| # ========= RBS =========== | ||
| Style/RbsInline/MissingTypeAnnotation: | ||
| EnforcedStyle: method_type_signature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.4.5 | ||
| 4.0.0 | ||
Syati marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,31 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| require 'bundler/gem_tasks' | ||
| require 'rspec/core/rake_task' | ||
| require 'steep/rake_task' | ||
|
|
||
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| require 'rubocop/rake_task' | ||
|
|
||
| RuboCop::RakeTask.new | ||
| Steep::RakeTask.new | ||
| # Use RBS Inline configuration for Ruby 3.3+ | ||
| rubocop_config = if RUBY_VERSION >= '3.3.0' | ||
| '.rubocop_rbs.yml' | ||
| else | ||
| '.rubocop.yml' | ||
| end | ||
|
|
||
| task default: %i[spec rubocop steep] | ||
| RuboCop::RakeTask.new do |task| | ||
| task.options = ['--config', rubocop_config] | ||
| end | ||
|
|
||
| # Steep is only available for Ruby 3.3+ | ||
| default_tasks = %i[spec rubocop] | ||
|
|
||
| if RUBY_VERSION >= '3.3.0' | ||
| require 'steep/rake_task' | ||
| Steep::RakeTask.new | ||
| default_tasks << :steep | ||
| end | ||
|
|
||
| task default: default_tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| # D = Steep::Diagnostic | ||
| target :lib do | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/usr/bin/env ruby | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| # Wrapper script for rubocop that automatically uses the correct config file | ||
| # based on Ruby version | ||
|
|
||
| config_file = if RUBY_VERSION >= '3.3.0' && File.exist?('.rubocop_rbs.yml') | ||
| '.rubocop_rbs.yml' | ||
| else | ||
| '.rubocop.yml' | ||
| end | ||
|
|
||
| exec('bundle', 'exec', 'rubocop', '--config', config_file, *ARGV) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| require 'spec_helper' | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| require 'spec_helper' | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # frozen_string_literal: true | ||
| # rbs_inline: enabled | ||
|
|
||
| require 'structured_params' | ||
| require 'rspec-parameterized' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.