-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Angular v19+ pending tasks and lazy derived signal proxy initialization #9986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjavicente
wants to merge
28
commits into
TanStack:main
Choose a base branch
from
benjavicente:angular-19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d64460c
docs(angular-query): add TypeScript documentation
arnoud-dv deb1dc5
Improve PendingTasks task cleanup, isRestoring() handling
arnoud-dv 4c82cd6
Ensure unit tests are run using component effect scheduling
arnoud-dv da89570
Use tracking to fix some subtle bugs
arnoud-dv 4b41009
Fix PendingTasks for offline mode
arnoud-dv 06e6507
Use queueMicrotask instead of notifyManager.batchCalls to improve timing
arnoud-dv 3d5331e
Fix isRestoring() handling
arnoud-dv e5f6028
add changeset
arnoud-dv d304fde
Improve tests
arnoud-dv 2969fb6
fix(angular-query): statically split proxy objects to avoid reading i…
benjavicente 9c84cc6
fix(angular-query): start pending task early and don't start on destr…
benjavicente bc8cd29
tests(angular-query): add pending task ssr render test
benjavicente acf3f71
fix(angular-query): inject query types and tests
benjavicente fd1d8fd
chore(angular-query): require angular 19 peer
benjavicente 220c955
fix(angular-query): infer select instead of skip-token like other sig…
benjavicente 82ebd09
docs(angular-query): consistency on examples and small improvements
benjavicente f85d697
chore(angular-query): fix eslint and knip warnings
benjavicente 10c29e1
chore(angular-query): remove compat pending tasks for angular <19
benjavicente edbe09e
tests(angular-query): only test supported ts versions of angular
benjavicente e46337b
tests(angular-query): assert other status narrowing on infinite queries
benjavicente 59dc8f7
docs(tanstack-query): other docs improvements
benjavicente 77fb483
docs(angular-query): remove status type narrowing example
benjavicente a318081
tests(angular-query): improve optimistic mutation test
benjavicente d086c9c
fix(angular-query): use signal observer in createBaseQuery
benjavicente 33ce3fa
docs(angular-query): fix typos
benjavicente 9202480
feat(angular-query): inject queries refractor + tests
benjavicente 0c2f8ad
feat(angular-query): update docs and references
benjavicente 55b78eb
feat(angular-query): address coderabbit comments
benjavicente File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/angular-query-experimental': minor | ||
| --- | ||
|
|
||
| require Angular v19+ and use Angular component effect scheduling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect data access pattern in
injectQueriesexample.Line 43 uses
this.userIds()butuserIdsis the query result object frominjectQuery, not a signal of the data. To access the selected user IDs, it should bethis.userIds.data().🔎 Proposed fix
// Then get the users messages userQueries = injectQueries(() => ({ - queries: (this.userIds() ?? []).map((userId) => ({ + queries: (this.userIds.data() ?? []).map((userId) => ({ queryKey: ['user', userId], queryFn: () => getUserById(userId), })), }))📝 Committable suggestion
🤖 Prompt for AI Agents