Conversation
jeslat
commented
Oct 28, 2025
| NEXUS_PASS: ${{ secrets.NEXUS_RELEASE_PASSWORD }} | ||
| run: | | ||
| ./gradlew publishReleasePublicationToSnapshotsRepository -DLIBRARY_VERSION=${{ github.event.inputs.snapshot-version }}-SNAPSHOT | ||
| ./gradlew publishReleasePublicationToMavenRepository -DLIBRARY_VERSION=${{ github.event.inputs.snapshot-version }}-SNAPSHOT |
jeslat
commented
Oct 28, 2025
Comment on lines
-11
to
+13
| url "https://nexusng.tuenti.io/repository/maven-release-private/" | ||
| def releasesRepoUrl = "https://nexusng.tuenti.io/repository/maven-release-private/" | ||
| def snapshotsRepoUrl = "https://nexusng.tuenti.io/repository/maven-snapshot-private/" | ||
| url = version.endsWith('SNAPSHOT') ? snapshotsRepoUrl : releasesRepoUrl |
Contributor
Author
There was a problem hiding this comment.
We have to define a different repo URL, taking into account the version suffix.
jeslat
commented
Oct 28, 2025
Comment on lines
-20
to
+22
| url "https://nexusng.tuenti.io/repository/maven-release-private/" | ||
| def releasesRepoUrl = "https://nexusng.tuenti.io/repository/maven-release-private/" | ||
| def snapshotsRepoUrl = "https://nexusng.tuenti.io/repository/maven-snapshot-private/" | ||
| url = version.endsWith('SNAPSHOT') ? snapshotsRepoUrl : releasesRepoUrl |
Contributor
Author
There was a problem hiding this comment.
The same for the library
There was a problem hiding this comment.
Pull Request Overview
This PR fixes snapshot artifact publishing by configuring dynamic repository selection based on version type (SNAPSHOT vs. release) and correcting the Gradle publish task reference.
Key changes:
- Replaced hardcoded repository URLs with conditional logic to route SNAPSHOT versions to the snapshots repository and regular versions to the releases repository
- Updated the GitHub Actions workflow to use the correct Gradle task name for publishing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mavencentral.gradle | Added conditional repository URL selection based on version suffix |
| include-build/mavencentral.gradle | Added conditional repository URL selection based on version suffix |
| .github/workflows/snapshot.yml | Corrected Gradle task name from publishReleasePublicationToSnapshotsRepository to publishReleasePublicationToMavenRepository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeslat
requested review from
a team,
dnieto-r and
juangardi21
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Fix snapshot generation
📘 Documentation changes?
🧪 How can I test this?