ANDROID-17070 Add optional reason to IgnoreLogs and IgnoreScreenshots#13
Merged
ANDROID-17070 Add optional reason to IgnoreLogs and IgnoreScreenshots#13
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds an optional reason parameter to the IgnoreLogs and IgnoreScreenshots annotations, following the pattern of JUnit's Ignore annotation to provide better documentation of why certain tests skip log or screenshot validation.
- Added optional
reason: Stringparameter with empty string default to both annotations - Updated test example to demonstrate usage with a reason string
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| android-snaptesting/src/main/java/com/telefonica/androidsnaptesting/Ignores.kt | Added optional reason parameter to IgnoreLogs and IgnoreScreenshots annotations |
| app/src/androidTest/java/com/telefonica/androidsnaptesting/ExampleInstrumentedTest.kt | Updated test to demonstrate usage of @IgnoreLogs with a reason string |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/androidTest/java/com/telefonica/androidsnaptesting/ExampleInstrumentedTest.kt
Show resolved
Hide resolved
jeslat
requested review from
a team,
bravoborja and
hjorrod
and removed request for
a team
hjorrod
approved these changes
Nov 3, 2025
bravoborja
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-17070
🥅 What's the goal?
Add an optional reason to
IgnoreLogsandIgnoreScreenshotsannotations. Similar to what is done in JUnitIgnoreannotation.📘 Documentation changes?