feat(U-Boot): add QoS configuration section #582
Closed
+62
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanbrattlof
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
bryanbrattlof,
devarsht,
gehariprasath,
jmenti,
praneethbajjuri,
r-vignesh and
uditkumarti
|
New issues found with check_toc_txt.py: |
|
New warnings found with rstcheck: |
bryanbrattlof
force-pushed
the
sdk11.2-qos
branch
3 times, most recently
from
792589f to
c2884e4
Compare
StaticRocket
requested changes
Dec 13, 2025
Member
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Vale comments about simple language an passive voice should probably be addressed
bryanbrattlof
force-pushed
the
sdk11.2-qos
branch
from
c2884e4 to
7995b38
Compare
|
New issues found with check_toc_txt.py: |
bryanbrattlof
force-pushed
the
sdk11.2-qos
branch
3 times, most recently
from
a17be0c to
12fdf23
Compare
Collaborator
Author
|
I took care of most of the Vale issues. What I scanned seems to be stuff I don't think we can fix unless I skipped over something. I also split up the file endings to a separate patch |
StaticRocket
requested changes
Dec 16, 2025
bryanbrattlof
force-pushed
the
sdk11.2-qos
branch
from
8c0767a to
60ec232
Compare
Member
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
There are still some lengthy sentences here that vale doesn't like. Going to let others voice opinions about that
cshilwant
added
the
stale
Simple invisible character fixes Signed-off-by: Bryan Brattlof <bb@ti.com>
Add basic documentation on how the CBASS QoS blocks function and how Sysconfig can be used to generate the files for U-Boot to apply during the SoC's bootup phase. Co-authored-by: Randolph Sapp <res.sapp@gmail.com> Signed-off-by: Bryan Brattlof <bb@ti.com>
bryanbrattlof
force-pushed
the
sdk11.2-qos
branch
from
60ec232 to
06cc12a
Compare
| linux/Documentation_Tarball | ||
|
|
||
| linux/Demo_User_Guides/Chromium_Browser No newline at end of file | ||
| linux/Demo_User_Guides/Chromium_Browser |
Collaborator
There was a problem hiding this comment.
Doesnt belong in this patch.
Collaborator
Author
There was a problem hiding this comment.
what patch are you referring? Do I need a separate PR to fix the white-space with this file before I update it?
StaticRocket
removed
the
stale
StaticRocket
requested changes
Feb 11, 2026
| ====================== | ||
|
|
||
| Most transactions default to the lowest priority (ASEL 0, Order ID 0). | ||
| During boot-up, `U-Boot can update`_ these settings using data from the. |
Member
There was a problem hiding this comment.
Suggested change
| During boot-up, `U-Boot can update`_ these settings using data from the. | |
| During boot-up, `U-Boot can update`_ these settings with data from the |
|
|
||
| Most transactions default to the lowest priority (ASEL 0, Order ID 0). | ||
| During boot-up, `U-Boot can update`_ these settings using data from the. | ||
| Sysconfig Tool which you can download or launch online `here`_. |
Member
There was a problem hiding this comment.
Suggested change
| Sysconfig Tool which you can download or launch online `here`_. | |
| Sysconfig Tool, which you can download or use online `here`_. |
|
|
||
| The Common Bus Architecture (CBASS) module includes Quality of Service | ||
| (QoS) blocks to route and prioritize SoC bus traffic. By adjusting | ||
| attributes like priority, Address Selection (ASEL), and Order ID |
Member
There was a problem hiding this comment.
Suggested change
| attributes like priority, Address Selection (ASEL), and Order ID | |
| attributes such as priority, Address Selection (ASEL), and Order ID |
| .. _U-Boot can update: https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/mach-k3/am62px/am62p5_init.c?ref_type=tags#L253 | ||
| .. _here: https://www.ti.com/tool/SYSCONFIG | ||
|
|
||
| The MCU+ SDK documentation has `an excellent guide`_ on how to to use the |
Member
There was a problem hiding this comment.
Suggested change
| The MCU+ SDK documentation has `an excellent guide`_ on how to to use the | |
| The MCU+ SDK documentation has `an excellent guide`_ on how to use the |
| .. note:: | ||
|
|
||
| Configuring the QoS blocks of a running system can cause issues. | ||
| You can only modify these settings during boot-up by the boot-loaders |
Member
There was a problem hiding this comment.
Suggested change
| You can only modify these settings during boot-up by the boot-loaders | |
| You can only change these settings during boot by using the boot-loaders, |
|
|
||
| For example, most K3 SoC External Memory Interface (EMIF) controllers | ||
| use two ports. Setting an Order ID between 8 and 15 routes traffic | ||
| through a high-priority port, ensuring it is serviced before standard |
Member
There was a problem hiding this comment.
Suggested change
| through a high-priority port, ensuring it is serviced before standard | |
| through a high-priority port, ensuring it gets serviced before standard |
Collaborator
Author
|
No. I've had enough. This has taken me 2 months to get through the nitpicking. So long in fact the people originally asking for this documentation are no longer with TI. I will be marking this a blocked until we get a proper copy editor. I have better things to do with my time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic documentation on how the CBASS QoS blocks function and how Sysconfig can be used to generate the files for U-Boot to apply during the SoC's bootup phase.