Open
Conversation
random is pseudorandom and follows an alogirthm that could be reverse engineered making secrets a better choice for password generation!
Author
|
Hey just an fyi but I saw your project while browsing github and I am making something similar, and I thought it would be a good chance to submit a pull request on someone else's project, never done that before and thought it would be cool! Just in case you were wondering why I submitted this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced random.choices with secrets.choices and added functionality to remove punctuation characters that are commonly not allowed to be used in passwords. Also just let my formatter organize the inputs to follow pep8 and then disabled my formatting to follow the existing standards used in the project.