chore: started replacing exceptions #3867
Open
+96
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noellie-velez
commented
Jan 30, 2026
| // prior to invoking OnNetworkSpawn so cross NetworkBehaviour: | ||
| // - accessing of NetworkVariables will work correctly. | ||
| // - invocation of RPCs will work properly (and not throw exception under certain scenarios) | ||
| // - invocation of RPCs will work properly (and not throw exception under certain scenarios) CHECK this comment about exceptions |
Collaborator
Author
There was a problem hiding this comment.
as we are removing exceptions we should remove (and not throw exception under certain scenarios), right?
noellie-velez
commented
Jan 30, 2026
| if (NetworkManager.Singleton.LogLevel <= LogLevel.Error) | ||
| { | ||
| NetworkLog.LogError("Could not serialize NetworkObject: Out of buffer space."); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I didn't catch why we didn't want to add a return here, is it correct not to add one for throwing an overflow exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
Link to related jira ticket (Use the smart commits). Short version (e.g. MTT-123) also works and gets auto-linked
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports