Open
Conversation
…ng multi-line imports and function parameters. Removed unused mobile device detection and sleep functions. No functional changes made. Signed-off-by: Luke Shiels <47612057+skve@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bryantanderson
requested changes
Jan 16, 2025
Contributor
bryantanderson
left a comment
bryantanderson
left a comment
There was a problem hiding this comment.
upon re-review, realized that this may break functionality for users with recording enabled
Author
|
what functionality exactly? we'd like to get this brought over the line |
|
The first message is always cut off when making the web call from my iPhone but it is not reproducible on desktop. It would be great to have this PR merged if fixes this as it's a bad UX. |
nikhilro
requested changes
Mar 8, 2025
| }, | ||
| }); | ||
|
|
||
| this.call.on('recording-started', () => { |
Contributor
There was a problem hiding this comment.
this logic is needed when people have video recording enabled
| // Allow mobile devices to finish processing the microphone permissions | ||
| // request before joining the call and playing the assistant's audio | ||
| if (this.isMobileDevice()) { | ||
| await this.sleep(1000); |
Contributor
There was a problem hiding this comment.
i think we likely still need this, keep both?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.