Update the installation description for wasmedge_rustls_plugin#176
Merged
hydai merged 2 commits intoWasmEdge:mainfrom Oct 22, 2023
Merged
Conversation
Starting with WasmEdge v0.13.4, the `wasmedge_rustls_plugin` has been bundled within the WasmEdge core (ref: https://github.com/WasmEdge/WasmEdge/releases/tag/0.13.4). Therefore, this patch modifies the installation instructions for rustls_plugin to indicate that it should be retrieved from the `WasmEdge/WasmEdge` repository, rather than from the `second-state/wasmedge_rustls_plugin`. Signed-off-by: moznion <moznion@mail.moznion.net>
Collaborator
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the patch successfully updates the installation description for DetailsCommit 903f58db89dc96efd4863e2e1cf6a4217b54b971Key changes in the patch:
Potential problems:
Overall, the patch updates the installation instructions for the Commit ec4fe3861f74ecd7f3b3e1120eb0d176dea7c60fKey changes in the patch:
Potential problems:
|
Contributor
|
Looks good to me, @hydai Could you please review this PR? :) |
hydai
requested changes
Oct 21, 2023
i18n/zh/docusaurus-plugin-content-docs/current/start/install.md
Outdated
Show resolved
Hide resolved
Signed-off-by: moznion <moznion@mail.moznion.net>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Starting with WasmEdge v0.13.4, the
wasmedge_rustls_pluginhas been bundled within the WasmEdge core (ref: https://github.com/WasmEdge/WasmEdge/releases/tag/0.13.4). Therefore, this patch modifies the installation instructions for rustls_plugin to indicate that it should be retrieved from theWasmEdge/WasmEdgerepository, rather than from thesecond-state/wasmedge_rustls_plugin.Related issue
This might be related to #108
What type of PR is this