Open
Conversation
Second editing session adds more details about Target system.
burg
force-pushed
the
eng/bburg/1209-inspector-site-isolation
branch
from
4adf9cc to
4842b9a
Compare
…cture Rewrites SiteIsolationExplainer.md with a complete, accurate description of the Web Inspector SI design: frame target lifecycle, BackendDispatcher fallback chain, the split UIProcess/WebProcess design for Network and Page domains (ProxyingNetworkAgent + NetworkAgentProxy), and open questions. Also adds a Web Inspector cross-reference section to SiteIsolation.md.
burg
changed the title
…cs, Security section - Rename to post-rename names: PageInspectorTargetProxy, FrameInspectorTargetProxy, FrameInspectorTarget, UIProcessForwardingFrontendChannel - Fix target type from WebPage to Page in Mode 1 and diagram - Replace hierarchy language with peer semantics in Mode 2 - Update code snippets to didCreateFrame/willDestroyFrame API - Add Security: Inspector-Only IPC Interfaces section explaining dynamic IPC receiver registration, conditional instrumentation, ordering guarantees, and per-page scoping - Update Compatibility section to avoid "sub-targets" framing - Add proxy agent source files to Key Source Files table
- Add table of contents with anchor links for all major sections - Remove BJB> working notes (phases bug links, domain placeholder, architect planning request)
Added per-domain migration status tables for all 19 inspector domains, covering both per-frame (11 domains) and octopus (8 domains) patterns. Added migration priority ordering and key architectural risks (Debugger single-VM problem, DOM cross-frame traversal, CSS coupling, Network RequestId collision).
szewai
reviewed
Feb 28, 2026
| |--------|--------|-------| | ||
| | **Console** | Done | `FrameConsoleAgent` landed; reference implementation for all per-frame agents | | ||
| | **Runtime** | In progress | `FrameRuntimeAgent` (PR [#59021](https://github.com/WebKit/WebKit/pull/59021)) | | ||
| | **Debugger** | Not started | Blocked on [bug 298909](https://bugs.webkit.org/show_bug.cgi?id=298909); single-debugger-multiple-agents challenge | |
There was a problem hiding this comment.
What is the current status of bug 298909? Is it being actively worked on?
| The **Browser** domain already lives entirely in `WebPageInspectorController` and requires | ||
| no migration. | ||
|
|
||
| ### Migration Priority Order |
There was a problem hiding this comment.
Can we explain a bit about how the order is decided? (I guess it's user impact plus dependency)
|
|
||
| --- | ||
|
|
||
| ## Key Source Files |
There was a problem hiding this comment.
May also include test files (or have a test section to talk about the testing plan, current pass rate with SI, cross-site frame coverage, etc)
|
|
||
| --- | ||
|
|
||
| ## Key Risks and Architectural Challenges |
There was a problem hiding this comment.
For these known risks, do we already have solution candidates? Or is it still in the exploratory phase (don't know how to resolve yet)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft and will be revised prior to pushing to prod.
(removed unhelpful commit template for now)