Skip to content

Add TodoMVC with indexedDB storage #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
issackjohn wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add TodoMVC with indexedDB storage #531

issackjohn wants to merge 29 commits into from

Conversation

@issackjohn
Copy link
Contributor

@issackjohn issackjohn commented Jan 30, 2026

Results for the hosted prototype as of 12/12/2025

label macos.arm64.local.0_0 macos.arm64.local.0_1 macos.arm64.local.0_2 macos.arm64.local.0_3
browser Microsoft Edge Firefox Google Chrome Safari
version 143.0.3650.80 146.0.0 143.0.7499.110 26.2.0.0.21623.1.14.11.9
os macos 26.2 arm64 macos 26.2 arm64 macos 26.2 arm64 macos 26.2 arm64
model MacBookPro17,1 MacBookPro17,1 MacBookPro17,1 MacBookPro17,1
cpu Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores
runs 5 5 5 5
failed runs 0 0 0 0
TodoMVC-WebComponents 2.71 ± 4.7% 3.760 ± 2.2% 2.87 ± 6.4% 4.129 ± 1.9%
TodoMVC-WebComponents-IndexedDB 32.29 ± 2.7% 32.50 ± 1.3% 35.61 ± 1.7% 40.07 ± 1.2%
TodoMVC-WebComponents-DexieJS 39.23 ± 2.3% 48.9 ± 2.5% 41.2 ± 2.5% 53.8 ± 2.0%
Score 68.1 ± 2.2% 55.53 ± 1.1% 62.9 ± 2.5% 48.37 ± 0.41%

@netlify
Copy link

netlify bot commented Jan 30, 2026 •
edited
Loading

✅ Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit 1e21b87
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/698a4ec837e8530008f829ee
😎 Deploy Preview https://deploy-preview-531--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@issackjohn issackjohn mentioned this pull request Jan 30, 2026
Closed
@issackjohn
Copy link
Contributor Author

issackjohn commented Jan 30, 2026

Opening a replacement PR to take over: The original PR author is no longer available. I copied the current branch state and will address existing review feedback here. Please see the old PR for historical context: #523 . If anything is missing, let me know and I’ll add it here.

@issackjohn issackjohn changed the title Issackjohn wc indexeddb Add TodoMVC with indexedDB storage Feb 5, 2026
Luis Pardo added 24 commits February 5, 2026 16:01
@issackjohn
Initial commite copy of updated wc implementation
b3d5042
@issackjohn
Add buttons, and move to next page functionality
7d83e7d
@issackjohn
Added indexed db functionality
2cc9977
@issackjohn
Implement add items step
a96d96d
@issackjohn
Added toggle step, pending delete step (logic to delete from the db?)
32efb62
@issackjohn
Add remove step
8b074f2
@issackjohn
Fix button order
5566de1
@issackjohn
Delete node_modules folder
175bb47
@issackjohn
Don't measure writing time
b78559c
@issackjohn
Remomve old indexeddb protype and wc changes
741bf07
@issackjohn
Update indexedDB to use latest version of wc
5a858ef
@issackjohn
Update test files
db24979
@issackjohn
Add dixiejs version and differentiate through the route
bc975a4
@issackjohn
Throw earlier when opening dbs
eeea2a0
@issackjohn
Update README
e04d2c3
@issackjohn
format and add coment
5a12708
@issackjohn
Remove unnecesary asyncs, use transaction commit and oncompleted in t…
f388b9d 
…he indexedDB version
@issackjohn
Use async functions, move tests to experimental folder
ee93eff
@issackjohn
Fix bad merge
191e9b7
@issackjohn
Vanilla indexedDb working
a67f387
@issackjohn
Use remote runner
5e21c77
@issackjohn
Properly exclude steps
1b12246
@issackjohn
Remove unused helpers in Page class
d3bc874
@issackjohn
Remove extra comments
39315c6
Luis Pardo and others added 4 commits February 5, 2026 16:02
@issackjohn
Fix incorrect usage of sync test runner, remove comments, close datab…
e1cdf03 
…ases
@issackjohn
Fix runner issues, improve promises
aaac0e0
@issackjohn
Addressed pr feedback (#42)
253f103 
* Fix typo in finishedAdditions variable name in BaseStorageManager

* Commit transaction after sorting items in getTodos method

* Simplify toggleTodo method by using update for completion status

* Fix sorting order comment in getTodos method for clarity
@issackjohn
Fix formatting in toggleTodo
d137671
@issackjohn issackjohn force-pushed the issackjohn-WCIndexeddb branch from 8383f2e to d137671 Compare February 6, 2026 00:02
@issackjohn issackjohn marked this pull request as ready for review February 9, 2026 21:46
@issackjohn
Copy link
Contributor Author

issackjohn commented Feb 9, 2026

@abhishek-shanthkumar I am unable to add you as a reviewer so could you please join as a reviewer? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flashdesignory flashdesignory Awaiting requested review from flashdesignory

@camillobruni camillobruni Awaiting requested review from camillobruni

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@issackjohn