Skip to content

Enable dumpInfoAndCrashForInvalidHandleV2 on non-Cocoa #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoikonomopoulos wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
Open

Enable dumpInfoAndCrashForInvalidHandleV2 on non-Cocoa #1633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Source/JavaScriptCore/heap/MarkedBlock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,16 +573,14 @@ NO_RETURN_DUE_TO_CRASH NEVER_INLINE void MarkedBlock::dumpInfoAndCrashForInvalid
}

auto updateCrashLogMsg = [&](int line) {
#if PLATFORM(COCOA)
StringPrintStream out;
out.printf("INVALID HANDLE [%d]: markedBlock=%p; heapCell=%p; cellFirst8Bytes=%#llx; subspaceHash=%#x; contiguousZeros=%lu; totalZeros=%lu; blockVM=%p; actualVM=%p; isBlockVMValid=%d; isBlockInSet=%d; isBlockInDir=%d; foundInBlockVM=%d;",
line, this, heapCell, cellFirst8Bytes, subspaceHash, contiguousZeroBytesHeadOfBlock, totalZeroBytesInBlock, blockVM, actualVM, isBlockVMValid, isBlockInSet, isBlockInDirectory, foundInBlockVM);
line, this, heapCell, static_cast<long long>(cellFirst8Bytes), subspaceHash, contiguousZeroBytesHeadOfBlock, totalZeroBytesInBlock, blockVM, actualVM, isBlockVMValid, isBlockInSet, isBlockInDirectory, foundInBlockVM);
auto message = out.toCString();
#if PLATFORM(COCOA)
WTF::setCrashLogMessage(message.data());
dataLogLn(message.data());
#else
UNUSED_PARAM(line);
#endif
dataLogLn(message.data());
};
updateCrashLogMsg(__LINE__);

Expand Down