Skip to content

Admin page registered with add_menu_page() allows access through wrong URls and hightlights wrong top level menu item #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikunj8866 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Admin page registered with add_menu_page() allows access through wrong URls and hightlights wrong top level menu item #10801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1604f3
refreshing 28821.diff
nikunj8866 Jan 27, 2026
1752898
fix phpcs error
nikunj8866 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/wp-admin/includes/plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2169,12 +2169,13 @@ function get_plugin_page_hookname( $plugin_page, $parent_page ) {
* @global array $_wp_submenu_nopriv
* @global string $plugin_page
* @global array $_registered_pages
* @global array $admin_page_hooks
*
* @return bool True if the current user can access the admin page, false otherwise.
*/
function user_can_access_admin_page() {
global $pagenow, $menu, $submenu, $_wp_menu_nopriv, $_wp_submenu_nopriv,
$plugin_page, $_registered_pages;
$plugin_page, $_registered_pages, $admin_page_hooks;

$parent = get_admin_page_parent();

Expand All @@ -2192,6 +2193,11 @@ function user_can_access_admin_page() {
if ( ! isset( $_registered_pages[ $hookname ] ) ) {
return false;
}

// It's a toplevel page, but accessed with the wrong parent.
if ( isset( $admin_page_hooks[ $plugin_page ] ) && $parent !== $plugin_page ) {
return false;
}
}

if ( empty( $parent ) ) {
Expand Down
Loading