Allow PHP-Only Block Registration#10932
Conversation
t-hamano
force-pushed
the
64639-php-auto-register-block
branch
2 times, most recently
from
6b3535e to
7d228d9
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
force-pushed
the
64639-php-auto-register-block
branch
from
ec4f677 to
6a7c802
Compare
t-hamano
force-pushed
the
64639-php-auto-register-block
branch
from
6a7c802 to
691cdf5
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| return $args; | ||
| } | ||
|
|
||
| foreach ( $args['attributes'] as $name => $def ) { |
There was a problem hiding this comment.
Can $def not be abbreviated? Would it be $definition? Or would it be better as $attribute_definition?
There was a problem hiding this comment.
I've changed it to $attr_key and $attr_schema for clarity, which is similar to the code here:
Co-authored-by: Weston Ruter <westonruter@gmail.com>
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64639
Use of AI Tools
I am using the Cursor editor and the AI model is auto-selected. I have reviewed all the code myself.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.