Update wp.sanitize.stripTags() to return empty string when not passed a string#10994
Update wp.sanitize.stripTags() to return empty string when not passed a string#10994westonruter wants to merge 1 commit intoWordPress:trunkfrom
wp.sanitize.stripTags() to return empty string when not passed a string#10994Conversation
… a string Co-authored-by: Dennis Snell <dmsnell@git.wordpress.org>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@Hug0-Drelon How does this work for you? |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
See #10833 (comment):
It turns out that passing a non-string in 6.9 would cause an error due to the
replace()method not being available on it (probably). So the previous change in r61578 which added support for sanitizing numbers actually would have previously caused an error. So we can indeed just short-circuit when a non-string is passed.Trac ticket: https://core.trac.wordpress.org/ticket/64574
Follow-up to:
wp.sanitize.stripTags()when input isnullorundefined#10833wp.sanitize.stripTags()when input is an empty value #10856Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.