Skip to content

Update tests; handle terms lists, as well #11051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joedolson wants to merge 4 commits into from
+6 −8
Closed

Update tests; handle terms lists, as well #11051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39e3661
Update tests; handle terms lists, as well
joedolson Feb 25, 2026
b170be0
Change to exact matches
joedolson Feb 25, 2026
78e158c
Overlooked instance
joedolson Feb 25, 2026
a3103f2
Extra braces no longer required.
joedolson Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/wp-admin/includes/class-wp-terms-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,8 @@ public function column_name( $tag ) {
$edit_link
);
$name = sprintf(
'<a class="row-title" href="%s" aria-label="%s">%s</a>',
'<a class="row-title" href="%s">%s</a>',
esc_url( $edit_link ),
/* translators: %s: Taxonomy term name. */
esc_attr( sprintf( __( '&#8220;%s&#8221; (Edit)' ), $tag->name ) ),
$name
);
}
Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/specs/edit-posts.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ test.describe( 'Edit Posts', () => {
await expect( listTable ).toBeVisible();

// Click the post title (edit) link
await listTable.getByRole( 'link', { name: `“${ title }” (Edit)` } ).click();
await listTable.getByRole( 'link', { name: title, exact: true } ).click();

// Wait for the editor iframe to load, and switch to it as the active content frame.
await page
Expand Down Expand Up @@ -84,7 +84,7 @@ test.describe( 'Edit Posts', () => {
await expect( listTable ).toBeVisible();

// // Focus on the post title link.
await listTable.getByRole( 'link', { name: `“${ title }” (Edit)` } ).focus();
await listTable.getByRole( 'link', { name: title, exact: true } ).focus();

// Tab to the Quick Edit button and press Enter to quick edit.
await pageUtils.pressKeys( 'Tab', { times: 2 } )
Expand Down Expand Up @@ -122,7 +122,7 @@ test.describe( 'Edit Posts', () => {
await expect( listTable ).toBeVisible();

// Focus on the post title link.
await listTable.getByRole( 'link', { name: `“${ title }” (Edit)` } ).focus();
await listTable.getByRole( 'link', { name: title, exact: true } ).focus();

// Tab to the Trash button and press Enter to delete the post.
await pageUtils.pressKeys( 'Tab', { times: 3 } )
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/specs/empty-trash-restore-trashed-posts.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test.describe( 'Empty Trash', () => {
await expect( listTable ).toBeVisible();

// Move post to trash
await listTable.getByRole( 'link', { name: `“${ POST_TITLE }” (Edit)` } ).hover();
await listTable.getByRole( 'link', { name: POST_TITLE, exact: true } ).hover();
await listTable.getByRole( 'link', { name: `Move “${POST_TITLE}” to the Trash` } ).click();

// Empty trash
Expand All @@ -40,7 +40,7 @@ test.describe( 'Empty Trash', () => {
await expect( listTable ).toBeVisible();

// Move post to trash
await listTable.getByRole( 'link', { name: `“${ POST_TITLE }” (Edit)` } ).hover();
await listTable.getByRole( 'link', { name: POST_TITLE, exact: true } ).hover();
await listTable.getByRole( 'link', { name: `Move “${POST_TITLE}” to the Trash` } ).click();

await page.getByRole( 'link', { name: 'Trash' } ).click();
Expand Down
Loading