Skip to content

Classic Editor: set background, positioning and height for Skip to Editor link#11053

Closed
sabernhardt wants to merge 3 commits intoWordPress:trunkfrom
sabernhardt:classic-editor-skip-link
Closed

Classic Editor: set background, positioning and height for Skip to Editor link#11053
sabernhardt wants to merge 3 commits intoWordPress:trunkfrom
sabernhardt:classic-editor-skip-link

Conversation

@sabernhardt
Copy link

  • Assigns the right positioning value regardless of whether the link has focus, to avoid horizontal scroll.
  • Sets the background color to white.
  • Reduces the line-height and min-height.
  • Keeps the top value of 4 pixels for any screen width.

Trac 64727

Use of AI Tools: none


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sabernhardt
Copy link
Author

The 32-pixel height matches the plugin action buttons (since r61729).

@sabernhardt
Copy link
Author

Trunk, before patch With patch
With focus, at 640px and 1000px
Before, with focus, at 640 pixels
Before, with focus, at 1000 pixels
With focus, at 640px and 1000px
After, with focus, at 640 pixels
After, with focus, at 1000 pixels
No focus, at 640px
Before, without focus, at 640 pixels
No focus, at 640px
After, without focus, at 640 pixels

For comparison, 6.9.1 had a smaller link:
WordPress 6.9, link visible with focus
And the horizontal scroll was less noticeable:
WordPress 6.9, without focus

@sabernhardt
Copy link
Author

Committed in r61742

@sabernhardt sabernhardt deleted the classic-editor-skip-link branch February 25, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant