Fix: Authenticated Git dependencies incorrectly parsed as npm alias#4766
Open
pantha704 wants to merge 2 commits intoaboutcode-org:developfrom
Open
Fix: Authenticated Git dependencies incorrectly parsed as npm alias#4766pantha704 wants to merge 2 commits intoaboutcode-org:developfrom
pantha704 wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
…NPM aliases in package.json dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4753. The package parser inside
npm.py'sdeps_mapperwas evaluating dependencies via a naive string check (if:and@exist in the requirement), which falsely captured authenticated git repos likegit+ssh://git@github.com...as aliases of package 'git'. This modifies the check strictly to require thenpm:prefix and an@delimiter, fixing both NPM package aliases and YarnLock dependency statements. Tests are included.