Skip to content

Comments

Changed: Update tooling, Rust version, and dependencies#19

Merged
acgetchell merged 2 commits intomainfrom
update/tooling-and-rust-version
Jan 31, 2026
Merged

Changed: Update tooling, Rust version, and dependencies#19
acgetchell merged 2 commits intomainfrom
update/tooling-and-rust-version

Conversation

@acgetchell
Copy link
Owner

@acgetchell acgetchell commented Jan 31, 2026

Updates several tooling versions in CI, including cspell and uv. Increases the minimum supported Rust version (MSRV) to 1.93. Renames WARP.md to AGENTS.md for broader applicability. Refreshes dependencies in Cargo.lock and pyproject.toml, including faer. Adds a type checker (ty) for Python scripts. (internal)

Summary by CodeRabbit

  • New Features

    • Plots now include detected dependency version labels in legends for clearer visualization.
    • Benchmarks and bench-related commands now support an explicit bench feature set.
  • Documentation

    • Contributing guidance updated to reference automated agents.
  • Chores

    • Updated Rust toolchain and CI tooling versions; added/updated dev tooling and spell dictionary; added Python type-check config.
  • Tests

    • Expanded tests for version detection, TOML parsing, plotting flows, and related utilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Updates several tooling versions in CI, including cspell and uv.
Increases the minimum supported Rust version (MSRV) to 1.93.
Renames WARP.md to AGENTS.md for broader applicability.
Refreshes dependencies in Cargo.lock and pyproject.toml, including faer.
Adds a type checker (ty) for Python scripts. (internal)
@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

Adds tooling/version bumps and minor workflow formatting, renames WARP.md → AGENTS.md, updates Cargo/toolchain and feature-driven bench config, adds Cargo.toml version detection and dynamic legend labels to the plotting script, expands tests, and adds ty-based Python typecheck config.

Changes

Cohort / File(s) Summary
CI Workflows
.github/workflows/ci.yml, .github/workflows/codecov.yml
Bumped CSPELL and UV versions; small formatting fixes to inline comments in workflow steps.
Rust Toolchain & Manifest
Cargo.toml, rust-toolchain.toml
Updated rust-version/toolchain 1.92 → 1.93; added optional bench dependencies (criterion, faer, nalgebra) and a bench feature; updated bench target to require the feature; added rust lints.
Project Config & Scripts
justfile, pyproject.toml, ty.toml, cspell.json
Added --features bench to bench commands, added ty dev dependency and ty.toml config, added "serde" to cspell dictionary, and adjusted coverage/typecheck commands.
Docs
AGENTS.md, README.md
Renamed WARP.md → AGENTS.md and updated contributing/help references accordingly.
Plotting Script (feature)
scripts/criterion_dim_plot.py
Added Cargo.toml parsing and version-detection helpers; added la_label, na_label, fa_label fields to PlotRequest; integrated version-derived legend labels and printing of detected versions.
Tests
scripts/tests/test_criterion_dim_plot.py
Expanded tests for TOML parsing, dependency-version helpers, legend formatting, dim discovery, CSV handling, rendering/main error paths; updated tests to include new PlotRequest label fields.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as "CLI (criterion_dim_plot.py)"
    participant FS as "Filesystem (Cargo.toml)"
    participant STDERR as "stderr"
    participant Plot as "SVG Plot Generator"

    CLI->>FS: read Cargo.toml
    FS-->>CLI: package & dependency versions
    CLI->>CLI: detect & format la_label/na_label/fa_label
    CLI->>STDERR: print detected versions
    CLI->>Plot: build PlotRequest (includes labels) and request SVG
    Plot-->>CLI: return svg output
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I nibble toml and chase the tags,

I stitch new labels, wag my flags,
Toolchains hop and workflows sing,
Tests applaud the version string,
A tiny hop — the plots take wing! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating tooling versions, Rust version, and dependencies across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update/tooling-and-rust-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@acgetchell
Copy link
Owner Author

@coderabbitai full review

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

✅ Actions performed

Full review triggered.

Enables the "bench" feature for criterion and other benchmark
dependencies. This allows running benchmarks using the command
`cargo bench --features bench`. It also ensures that benchmarks
are compiled with warnings treated as errors by adding the
`--features bench` flag to the `bench-compile` target.
The coverage exclude has also been simplified.
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (5520283) to head (d701b58).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   92.06%   92.59%   +0.52%     
==========================================
  Files           4        4              
  Lines         189      189              
==========================================
+ Hits          174      175       +1     
+ Misses         15       14       -1     
Flag Coverage Δ
unittests 92.59% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acgetchell acgetchell merged commit 42a24d6 into main Jan 31, 2026
10 checks passed
@acgetchell acgetchell deleted the update/tooling-and-rust-version branch January 31, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant