Skip to content

fix: export fromDateToLocal#9548

Merged
yihuiliao merged 4 commits intoadobe:mainfrom
maximepvrt:patch-1
Feb 10, 2026
Merged

fix: export fromDateToLocal#9548
yihuiliao merged 4 commits intoadobe:mainfrom
maximepvrt:patch-1

Conversation

@maximepvrt
Copy link
Contributor

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We'll need to add a description jsdoc to the function and add it to our documentation as well, would you like to handle that?

You'll also need to sign the CLA

Please sign the Adobe CLA! Once signed, close and re-open your pull request to run the check again.

toTimeZone,
toLocalTimeZone,
fromDate,
fromDateToLocal,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh... we don't use this function anywhere in our codebase, @devongovett what was the intent here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowystinger I discovered this function while trying to use fromDate without a timezone. Is there a reason we didn’t just make the timezone optional and keep a single function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowystinger dit you see my reply ?

devongovett
devongovett previously approved these changes Feb 6, 2026
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as a shortcut. We should add a JSDoc comment to the function and add to the documentation page though.

Also @maximepvrt you'll need to sign the CLA.

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

@yihuiliao yihuiliao changed the title export fromDateToLocal feat: export fromDateToLocal Feb 10, 2026
@yihuiliao yihuiliao changed the title feat: export fromDateToLocal fix: export fromDateToLocal Feb 10, 2026
@yihuiliao yihuiliao added this pull request to the merge queue Feb 10, 2026
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label Feb 10, 2026
Merged via the queue into adobe:main with commit 8d21899 Feb 10, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session ready for review small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants