Fix the condition for rocket take off#51
Open
gtanczyk wants to merge 1 commit intoalexgurr:masterfrom
Open
Conversation
It should start after 5 seconds, and do not come back.
Owner
|
This looks like a solution to me (albeit not the correct one either). If i'm wrong, please add a comment explaining your fix. |
Author
|
Currently the rocket starts immediately after page load, and comebacks after 5 seconds. My PR is not supposed to provide a solution to the coding task, but rather fix this little quirk. The solution to the coding task is elsewhere anyway. |
Author
|
@alexgurr is the intention to expect the candidate to spot&fix this problem? |
Owner
|
Interesting, I've never spotted this. Let me verify the problem/fix. This is not part of the challenge :) |
boylerplet
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should start after 5 seconds, and do not come back.