Use isSystemInDarkTheme as default value in Theming Codelab and preview function name#521
Open
mkar-dev wants to merge 1 commit intoandroid:mainfrom
Open
Use isSystemInDarkTheme as default value in Theming Codelab and preview function name#521mkar-dev wants to merge 1 commit intoandroid:mainfrom
mkar-dev wants to merge 1 commit intoandroid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the starting point for Theming Codelab has default value for checking dark theme set to
falseinstead ofisSystemInDarkTheme()It doesn't seem intentional for me and can be confusing for beginners
Also - the name for preview function is
ReplyAppPreviewLighteven though it generates preview for both Dark and Light themesReplyAppPreviewseems more fitting