This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Add dependency on bootstrap.css file#63
Open
fcagalj wants to merge 1 commit intoangular-ui:masterfrom
Open
Conversation
…strap-css-only which hold bootstrap.css
Member
|
I don't think we should do this as it points to a non-official source and we don't have any guarantee that this source is reliable and up-to-date. For example, the last commit in the mentioned repo was done on Mar 20, the latest version is v3.3.4 versus released bs 3.3.5 etc. |
Author
|
Ok I agree, but issue should be solved or documented... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update bower.json to add dependency on https://github.com/fyockm/bootstrap-css-only which holds bootstrap.css, to avoid installing regular bootstrap which depend on jQuery, or adding bootstrap.css manually.