feat(@schematics/angular): replace favicon.ico with favicon.png #32454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the legacy favicon.ico with a modern PNG favicon in the application schematic. Updated index.html template to reference favicon.png with correct MIME type. Fixes angular#11275
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
bot
added
detected: feature
Member
|
There is no value to replace the favicon with a low res PNG. Also the png is with the old logo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the legacy favicon.ico with a modern PNG favicon in the application schematic. Updated index.html template to reference favicon.png with correct MIME type.
Fixes #11275
PR Checklist
PR Type
What is the current behavior?
The
ng newcommand generates a legacy favicon.ico file and adds a link tag withtype="image/x-icon"to theindex.html.Issue Number: #11275
What is the new behavior?
The
ng newcommand now generates a modernfavicon.pngfile. Theindex.htmltemplate is updated to use<link rel="icon" type="image/png" href="favicon.png">. Existing schematic tests have been updated to reflect this change.Does this PR introduce a breaking change?
Other information
The SVG favicon mentioned in the issue was not included to ensure maximum browser compatibility as a default, focusing on the PNG replacement requested.