Skip to content

fix(aria/menu): Add label property for proper aria-label #32710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adolgachev merged 1 commit into from
Jan 30, 2026
+2 −1
Merged

fix(aria/menu): Add label property for proper aria-label #32710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aria/menu/menu-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import type {MenuBar} from './menu-bar';
'(focusin)': '_pattern.onFocusIn()',
'[attr.tabindex]': '_pattern.tabIndex()',
'[attr.data-active]': 'active()',
'[attr.aria-label]': 'value()',
'[attr.aria-haspopup]': 'hasPopup()',
'[attr.aria-expanded]': 'expanded()',
'[attr.aria-disabled]': '_pattern.disabled()',
Expand All @@ -54,7 +55,7 @@ export class MenuItem<V> {
/** The unique ID of the menu item. */
readonly id = input(inject(_IdGenerator).getId('ng-menu-item-', true));

/** The value of the menu item. */
/** The value of the menu item, used as the default aria-label */
readonly value = input.required<V>();

/** Whether the menu item is disabled. */
Expand Down
Loading