docs(google-maps): use inject() instead of constructor injection in examples#32836
Open
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Open
docs(google-maps): use inject() instead of constructor injection in examples#32836yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation update.
What is the current behavior?
The
MapGeocoderandMapDirectionsRendererREADME examples use constructorinjection to obtain services. The
MapDirectionsRendererexample is alsomissing the
import {map} from 'rxjs/operators'import and has inconsistentindentation on the
importsarray.What is the new behavior?
inject()instead of constructor injection, consistent with the modernAngular standalone pattern used across the rest of the docs.
import {map} from 'rxjs/operators'to the directionsrenderer example so the code compiles as shown.
importsarray in the directions renderer example.of assigning inside the constructor.
Additional context
Both
MapGeocoderandMapDirectionsServiceareprovidedIn: 'root', so theywork with
inject()without any additional provider configuration.