UnitsNetBaseJsonConverter minor bug fix for compatibility with UnitsNet 6.0.0-pre017#1637
Open
andrewmeservy wants to merge 2 commits intoangularsen:masterfrom
Open
Conversation
Contributor
Author
|
not sure why build checks fail - I didn't change that much and they seem like permissions errors rather than something with the code? lmk if there is something I need to do on my end! |
Owner
|
Thanks, what use case does this fix exactly? I'm going to hold off on merging this until after #1544 , since it already touches hard onto serialization and I want to avoid merge conflicts towards it. It can take some time to get that merged though, I have had little time to spare on this project lately, but maybe in the upcoming holidays. |
Owner
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The fix simply replaces a null forgiving operator with an actual null-check and return. It will throw an exception if it fails the null check.