Skip to content

UnitsNetBaseJsonConverter minor bug fix for compatibility with UnitsNet 6.0.0-pre017#1637

Open
andrewmeservy wants to merge 2 commits intoangularsen:masterfrom
andrewmeservy:jsonconverter-compatibility-patch
Open

UnitsNetBaseJsonConverter minor bug fix for compatibility with UnitsNet 6.0.0-pre017#1637
andrewmeservy wants to merge 2 commits intoangularsen:masterfrom
andrewmeservy:jsonconverter-compatibility-patch

Conversation

@andrewmeservy
Copy link
Contributor

  • Simple bug fix to make UnitsNet.Serialization.JsonNet compatible with the newest prerelease version of UnitsNet (6.0.0-pre017)

The fix simply replaces a null forgiving operator with an actual null-check and return. It will throw an exception if it fails the null check.

@andrewmeservy
Copy link
Contributor Author

not sure why build checks fail - I didn't change that much and they seem like permissions errors rather than something with the code? lmk if there is something I need to do on my end!

@angularsen
Copy link
Owner

Thanks, what use case does this fix exactly?

I'm going to hold off on merging this until after #1544 , since it already touches hard onto serialization and I want to avoid merge conflicts towards it.

It can take some time to get that merged though, I have had little time to spare on this project lately, but maybe in the upcoming holidays.

@angularsen
Copy link
Owner

not sure why build checks fail - I didn't change that much and they seem like permissions errors rather than something with the code? lmk if there is something I need to do on my end!

No idea, seems like a hiccup in the build. Other PR builds are fine. I'll requeue this one.

https://dev.azure.com/unitsnet/Units.NET/_build/results?buildId=1410&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=7bf8b4d7-347c-5dd5-5473-a01d1b8b437c

Starting: Install .NET nanoFramework MSBuild components
==============================================================================
Task         : Install .NET nanoFramework MSBuild components
Description  : Install .NET nanoFramework MSBuild components allowing building a .NET nanoFramework C# application with msbuild.
Version      : 1.256.0
Author       : .NET nanoFramework Project Contributors
Help         : 
==============================================================================
VS is: Visual Studio Enterprise 2022
##[error]The remote server returned an error: (403) Forbidden.
Finishing: Install .NET nanoFramework MSBuild components
image

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants