fix(opencode): execute subtask tool calls in parallel#14196
Open
gareys wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): execute subtask tool calls in parallel#14196gareys wants to merge 1 commit intoanomalyco:devfrom
gareys wants to merge 1 commit intoanomalyco:devfrom
Conversation
When an LLM response contains multiple Task tool calls, they are now executed concurrently via Promise.all instead of sequentially. Single subtasks still run directly with no overhead. Compaction tasks are unaffected.
Collaborator
|
left comment on issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14195. When an LLM response contains multiple Task tool calls (subtasks), the session loop previously popped one at a time and awaited each sequentially. This change collects all subtask parts from a response and runs them via
Promise.allwhen there are multiple. Single subtasks still run directly. Compaction tasks are unaffected (they use a separate code path).The core change is in
packages/opencode/src/session/prompt.ts: subtask execution is extracted into an async function, and the loop branches onsubtasks.length > 1to decide between sequential and parallel execution.How did you verify your code works?
./packages/opencode/script/build.ts --singlebun turbo typecheck— all 12 packages)