fix(core): normalize file.status paths relative to instance dir#14207
Open
shantur wants to merge 1 commit intoanomalyco:devfrom
Open
fix(core): normalize file.status paths relative to instance dir#14207shantur wants to merge 1 commit intoanomalyco:devfrom
shantur wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
8e9fd40 to
c3f3c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
None
Type of change
What does this PR do?
file.status returns incorrect/unstable file paths when x-opencode-directory points inside a repo (including git worktrees) because it runs path.relative(Instance.directory, x.path) on git-provided paths that are already relative, causing bogus ../... paths and inconsistent results depending on server cwd and request directory.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Manual API verification and tested with NeuralNomadsAI/CodeNomad#180
Screenshots / recordings
Pre Change
Post Change
Checklist
If you do not follow this template your PR will be automatically rejected.