GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues#49223
GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues#49223jonkeane wants to merge 1 commit intoapache:mainfrom
Conversation
|
@github-actions crossbow submit test-r-macos-as-cran |
|
Revision: 3de62b9 Submitted crossbow builds: ursacomputing/crossbow @ actions-d2851fb5d3
|
|
@github-actions crossbow submit test-r-macos-as-cran |
|
Revision: b7f6771 Submitted crossbow builds: ursacomputing/crossbow @ actions-b0f1f7caea
|
jonkeane
force-pushed
the
sparse_tensor_cxx20
branch
from
b7f6771 to
ab4d296
Compare
|
@github-actions crossbow submit test-r-macos-as-cran |
|
Revision: ab4d296 Submitted crossbow builds: ursacomputing/crossbow @ actions-9260141237
|
jonkeane
changed the title
|
The failure for the old SDK crossbow job is resolved by #49221 We should merge that PR first, and rerun the CI jobs here to confirm this is the last place we need to fix. |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1, but can you rebase now that the other PR is merged?
jonkeane
force-pushed
the
sparse_tensor_cxx20
branch
from
ab4d296 to
63df31a
Compare
|
@github-actions crossbow submit test-r-macos-as-cran |
|
Revision: 63df31a Submitted crossbow builds: ursacomputing/crossbow @ actions-7c27c3c492
|
jonkeane
force-pushed
the
sparse_tensor_cxx20
branch
from
63df31a to
2eac5f2
Compare
|
🎉 I've rebased and we're good (and a bit relieved there weren't more places we'll need this workarounds) |
2 participants
Now that we have CI for it, check on other issues with C++20 compatibility on CRAN. I know that the code in #49105 is likely problematic
Resolves: #49287
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?