-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36411: [Python] Use scikit-build-core as build backend for PyArrow and get rid of setup.py #49259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GH-36411: [Python] Use scikit-build-core as build backend for PyArrow and get rid of setup.py #49259
Changes from all commits
fb253b4
765e3ba
8732d38
0332d2e
c675ee7
d3d25bf
8ac25ca
3f9fd78
f272755
3463122
26780d7
45e49ba
af9fe7b
62df334
529694f
61f3023
9fa8572
f2f7e17
5c5531c
70463e4
fabf672
af1f099
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,5 +29,5 @@ numpy>=1.16.6 | |
| pytest | ||
| pytest-faulthandler | ||
| s3fs>=2023.10.0 | ||
| setuptools>=77 | ||
| scikit-build-core | ||
| setuptools_scm>=8 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,10 +111,7 @@ echo "=== CCACHE Stats after build ===" | |
| ccache -sv | ||
|
|
||
| echo "=== Building Python ===" | ||
| set PYARROW_BUILD_TYPE=%CMAKE_BUILD_TYPE% | ||
| set PYARROW_BUILD_VERBOSE=1 | ||
| set PYARROW_BUNDLE_ARROW_CPP=ON | ||
| set PYARROW_CMAKE_GENERATOR=%CMAKE_GENERATOR% | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does scikit-build-core pick up the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on other changes you did, it doesn't seem it does?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't pick the |
||
| set PYARROW_WITH_ACERO=%ARROW_ACERO% | ||
| set PYARROW_WITH_AZURE=%ARROW_AZURE% | ||
| set PYARROW_WITH_DATASET=%ARROW_DATASET% | ||
|
|
@@ -137,6 +134,6 @@ pushd %SOURCE_DIR%\python | |
| %PYTHON_CMD% -m pip install -r requirements-build.txt || exit /B 1 | ||
|
|
||
| @REM Build PyArrow | ||
| %PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv . || exit /B 1 | ||
| %PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv -C build.verbose=true . || exit /B 1 | ||
|
|
||
| popd | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rely on
pyproject.tomlfor build dependencies at some point?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that we are already facing (not strictly related to this PR). I've opened an enhancement for it:
pyproject.tomlfor build dependencies #49398