GH-48408: [C++] Enable ULP-based float comparison#49290
Open
andishgar wants to merge 2 commits intoapache:mainfrom
Open
GH-48408: [C++] Enable ULP-based float comparison#49290andishgar wants to merge 2 commits intoapache:mainfrom
andishgar wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
andishgar
force-pushed
the
enable_ulp_based_comparison
branch
from
c79f91f to
9cd0147
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Enable ULP-based floating-point comparison.
What changes are included in this PR?
Add
arrow::EqualOptions::use_ulp_distanceandarrow::EqualOptions::ulp_distance.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. The ULP-based comparison method is enabled via
arrow::EqualOptions::use_ulp_distanceandarrow::EqualOptions::ulp_distance.