GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls#49301
Open
nateprewitt wants to merge 1 commit intoapache:mainfrom
Open
GH-49169: [C++] Add ApplicationId to AzureFileSystem for SDK calls#49301nateprewitt wants to merge 1 commit intoapache:mainfrom
nateprewitt wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
kou
reviewed
Feb 17, 2026
| } | ||
| Blobs::BlobClientOptions client_options; | ||
| client_options.Telemetry.ApplicationId = | ||
| "azpartner-arrow/" + GetBuildInfo().version_string; |
Member
There was a problem hiding this comment.
Could you create an internal function that returns this string and share it in 2 locations?
github-actions
bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After discussion in #49169, this PR will add a unique identifier to the AzureFileSystem implementation to distinguish calls from the base Azure C++ SDK.
What changes are included in this PR?
This PR adds
azpartner-arrow/{verion}as the ApplicationId used by AzureFileSystem.Are these changes tested?
The change has been manually validated. I'm happy to add a test for its persistence, but I wasn't sure what level you'd like to see in Arrow. This is effectively just plumbing a string to the SDK. The ApplicationId functionality is validated in the SDK test suite.
Are there any user-facing changes?
This shouldn't be user facing. Only a user-agent update for the underlying SDK.