Add States for Pause

[tarun-google]

Add States for Pausing and Paused.

Paused -> Stopped (not a terminal state)
Pausing -> Running

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the MonitoringUtil class by incorporating new Dataflow job states related to pausing. It establishes clear mappings for JOB_STATE_PAUSED to State.STOPPED and JOB_STATE_PAUSING to State.RUNNING, ensuring that the system accurately interprets and reflects these job statuses. Comprehensive unit tests have been added to validate these new state transitions.

Highlights

• New Job States: Introduced two new job states, JOB_STATE_PAUSED and JOB_STATE_PAUSING, to better reflect the lifecycle of Dataflow jobs.
• State Mapping for Paused Jobs: Mapped JOB_STATE_PAUSED to the existing State.STOPPED enum, as it represents a non-terminal, inactive state.
• State Mapping for Pausing Jobs: Mapped JOB_STATE_PAUSING to the existing State.RUNNING enum, indicating that the job is still active during the pausing transition.
• Unit Test Coverage: Added corresponding unit tests in MonitoringUtilTest.java to ensure the correct mapping of these new job states.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java
  • Added JOB_STATE_PAUSED to be mapped to State.STOPPED.
  • Added JOB_STATE_PAUSING to be mapped to State.RUNNING.
• runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/MonitoringUtilTest.java
  • Added test cases for JOB_STATE_PAUSED mapping to State.STOPPED.
  • Added test cases for JOB_STATE_PAUSING mapping to State.RUNNING.

Activity

• The pull request was created by tarun-google to add new states for pausing Dataflow jobs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @jrmccluskey added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[tarun-google]

R: @damccorm

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[jonathan-lemos]

I'm not a committer so I can't merge this, but this LGTM

[damccorm]

Thanks!

[damccorm]

Thanks!