Skip to content

ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection#11706

Merged
borisstoyanov merged 4 commits intoapache:4.22from
shapeblue:ui-fix-doubledatafetch-ownerselection-main
Jan 27, 2026
Merged

ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection#11706
borisstoyanov merged 4 commits intoapache:4.22from
shapeblue:ui-fix-doubledatafetch-ownerselection-main

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Sep 24, 2025

Description

Related #11705

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: fix form data double fetch/reset DeployVMFromBackup form data by …
e48c8c7 
…ownership selection

Related apache#11705

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.59%. Comparing base (3828a3b) to head (23d54fd).
⚠️ Report is 38 commits behind head on 4.22.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #11706      +/-   ##
============================================
- Coverage     17.59%   17.59%   -0.01%     
+ Complexity    15601    15600       -1     
============================================
  Files          5910     5910              
  Lines        529819   529820       +1     
  Branches      64730    64731       +1     
============================================
- Hits          93225    93222       -3     
- Misses       426099   426103       +4     
  Partials      10495    10495
Flag Coverage Δ
uitests 3.60% <ø> (-0.01%) ⬇️
unittests 18.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 24, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Sep 24, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 24, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-761)

@shwstppr shwstppr marked this pull request as ready for review September 24, 2025 14:45
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Sep 24, 2025

@shwstppr , why not put these in the same PR with #11705 ? The changes in OwnershipSelection.vue seems exactly the same?

@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 24, 2025

@DaanHoogland because DeployVMFromBackup is not present in 4.20 for which #11705 is targeted

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Sep 24, 2025

Cool, so the changes in OwnershipSelection.vue will be the merge forward conflict. Of which notice!

DaanHoogland
DaanHoogland approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Sep 25, 2025
@shwstppr
fix
4b9f86c 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 25, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Sep 25, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 25, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-763)

@shwstppr
fix
84795f1 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 25, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Sep 25, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 25, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-765)

@harikrishna-patnala harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025
@shwstppr shwstppr requested a review from abh1sar November 28, 2025 05:49
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026
@rajujith
Copy link

rajujith commented Jan 12, 2026

@shwstppr Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

@shwstppr shwstppr changed the base branch from main to 4.22 January 12, 2026 07:54
@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 12, 2026

@rajujith done

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 12, 2026

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 12, 2026

@rajujith done

sorry to jump in late @shwstppr , but isn’t this relevant for 4.20 as well?

abh1sar
abh1sar approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

blueorangutan commented Jan 12, 2026

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-841)

@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 12, 2026

@rajujith done

sorry to jump in late @shwstppr , but isn’t this relevant for 4.20 as well?

@DaanHoogland no, DeployVMFromBackup form was added after 4.20. For 4.20 specific, we've #11705

@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 20, 2026

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 20, 2026

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 20, 2026

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11706 (QA-JID-850)

harikrishna-patnala
harikrishna-patnala approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. can be merged based on the PR changes #11705

@borisstoyanov borisstoyanov merged commit d722c95 into apache:4.22 Jan 27, 2026
26 checks passed
@DaanHoogland DaanHoogland deleted the ui-fix-doubledatafetch-ownerselection-main branch January 27, 2026 14:16
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
@shwstppr
ui: fix form data double fetch/reset DeployVMFromBackup form data by …
865edb3 
…ownership selection (apache#11706)

* ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection

Related apache#11705

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

+1 more reviewer

@abh1sar abh1sar abh1sar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:UI

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

7 participants

@shwstppr @blueorangutan @DaanHoogland @rajujith @harikrishna-patnala @abh1sar @borisstoyanov