[VMware to KVM migration] Check source VM against the selected offering

[nvazquez]

Description

This PR adds checks on the source VM against the selected offering for VMware import to KVM

Fixes: #11868

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Pearl1594]

code lgtm.

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (941227e) to head (46c5399).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java	71.42%	1 Missing and 5 partials ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	83.33%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11908   +/-   ##
=========================================
  Coverage     17.55%   17.56%           
- Complexity    15531    15543   +12     
=========================================
  Files          5909     5909           
  Lines        529008   529045   +37     
  Branches      64605    64615   +10     
=========================================
+ Hits          92893    92943   +50     
+ Misses       425669   425647   -22     
- Partials      10446    10455    +9     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.63% <76.92%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15550

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15551

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[harikrishna-patnala]

code LGTM

[blueorangutan]

[SF] Trillian test result (tid-14724)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 73451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11908-t14724-kvm-ol8.zip
Smoke tests completed. 147 look OK, 1 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	3688.88	test_kubernetes_clusters.py
all_test_human_readable_logs	Skipped	---	test_human_readable_logs.py