Add volumes in 'Expunging' state to storage cleanup thread and during delete storage pool#12602
Open
sureshanaparti wants to merge 1 commit intoapache:4.20from
Open
Add volumes in 'Expunging' state to storage cleanup thread and during delete storage pool#12602sureshanaparti wants to merge 1 commit intoapache:4.20from
sureshanaparti wants to merge 1 commit intoapache:4.20from
Conversation
… delete storage pool
dd23e40 to
ca2552d
Compare
Contributor
Author
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12602 +/- ##
=========================================
Coverage 16.26% 16.27%
- Complexity 13429 13430 +1
=========================================
Files 5661 5661
Lines 500010 500011 +1
Branches 60715 60717 +2
=========================================
+ Hits 81331 81353 +22
+ Misses 409606 409585 -21
Partials 9073 9073
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds volumes in 'Expunging' state to storage cleanup thread and during delete storage pool.
There are some scenarios where volumes that get stuck in Expunging due to failure in the Expunge flow (and no failure callback received - due to Management server crash/restart, network loss etc), but not reverting back to Destroy state. They remain stuck in that state and expunge on them is never attempted leaving these volumes on the storage.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?