Skip to content

Add volumes in 'Expunging' state to storage cleanup thread and during delete storage pool#12602

Open
sureshanaparti wants to merge 1 commit intoapache:4.20from
shapeblue:cleanup-volumes-in-expunging-state
Open

Add volumes in 'Expunging' state to storage cleanup thread and during delete storage pool#12602
sureshanaparti wants to merge 1 commit intoapache:4.20from
shapeblue:cleanup-volumes-in-expunging-state

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Feb 6, 2026

Description

This PR adds volumes in 'Expunging' state to storage cleanup thread and during delete storage pool.

There are some scenarios where volumes that get stuck in Expunging due to failure in the Expunge flow (and no failure callback received - due to Management server crash/restart, network loss etc), but not reverting back to Destroy state. They remain stuck in that state and expunge on them is never attempted leaving these volumes on the storage.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti changed the title Add volumes in 'Expunging' state in storage cleanup thread and during delete storage pool Add volumes in 'Expunging' state to storage cleanup thread and during delete storage pool Feb 6, 2026
@sureshanaparti sureshanaparti force-pushed the cleanup-volumes-in-expunging-state branch from dd23e40 to ca2552d Compare February 6, 2026 06:48
@sureshanaparti sureshanaparti added this to the 4.20.3 milestone Feb 6, 2026
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.27%. Comparing base (3d7d412) to head (ca2552d).

Files with missing lines Patch % Lines
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java 0.00% 4 Missing ⚠️
...e/cloudstack/storage/volume/VolumeServiceImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12602   +/-   ##
=========================================
  Coverage     16.26%   16.27%           
- Complexity    13429    13430    +1     
=========================================
  Files          5661     5661           
  Lines        500010   500011    +1     
  Branches      60715    60717    +2     
=========================================
+ Hits          81331    81353   +22     
+ Misses       409606   409585   -21     
  Partials       9073     9073           
Flag Coverage Δ
uitests 4.15% <ø> (ø)
unittests 17.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants