Draft
Conversation
Author
|
Hi @hsiang-c, can you take a look, thanks! |
YutaLin
force-pushed
the
feat/url_encode_expression
branch
from
7a928b5 to
620c577
Compare
hsiang-c
reviewed
Feb 12, 2026
| /// - Special characters '.', '-', '*', '_' are not encoded | ||
| /// - All other characters are percent-encoded using UTF-8 bytes | ||
| #[derive(Debug, PartialEq, Eq, Hash)] | ||
| pub struct SparkUrlEncode { |
Contributor
There was a problem hiding this comment.
It seems like DataFusion has it: apache/datafusion#17399
Maybe we can just use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3185.
Rationale for this change
Comet does not currently support the Spark url_encode function, causing queries using this function to fall back to Spark's JVM execution instead of running natively on DataFusion.
The UrlEncode expression performs URL encoding (percent encoding) on a string input, converting special characters to their percent-encoded equivalents. This expression is implemented as a runtime replaceable expression that delegates to the UrlCodec.encode method for the actual encoding logic.
What changes are included in this PR?
Add native url encode function and staticinvoke urlencode object
How are these changes tested?
add url encode sql test and rs test