MSSQL: Add support for WAITFOR statement#2210
Open
guan404ming wants to merge 1 commit intoapache:mainfrom
Open
MSSQL: Add support for WAITFOR statement#2210guan404ming wants to merge 1 commit intoapache:mainfrom
guan404ming wants to merge 1 commit intoapache:mainfrom
Conversation
guan404ming
force-pushed
the
mssql-waitfor-statement
branch
from
e1f9899 to
30ec0a5
Compare
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
guan404ming
force-pushed
the
mssql-waitfor-statement
branch
from
30ec0a5 to
c89aa7e
Compare
iffyio
reviewed
Feb 14, 2026
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
Thanks @guan404ming! Just one minor comment re the tests otherwise this looks good to me
| fn test_parse_waitfor() { | ||
| // WAITFOR DELAY | ||
| let sql = "WAITFOR DELAY '00:00:05'"; | ||
| let stmt = ms().verified_stmt(sql); |
Contributor
There was a problem hiding this comment.
Suggested change
| let stmt = ms().verified_stmt(sql); | |
| let stmt = ms_and_generic().verified_stmt(sql); |
Can we have the tests cover the generic syntax?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MSSQL's WAITFOR statement (DELAY/TIME) was not supported by the parser.
How