minor: remove unused crypto functions & narrow public API #20045
+47
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Jan 28, 2026
Comment on lines
-40
to
-53
| macro_rules! define_digest_function { | ||
| ($NAME: ident, $METHOD: ident, $DOC: expr) => { | ||
| #[doc = $DOC] | ||
| pub fn $NAME(args: &[ColumnarValue]) -> Result<ColumnarValue> { | ||
| let [data] = take_function_args(&DigestAlgorithm::$METHOD.to_string(), args)?; | ||
| digest_process(data, DigestAlgorithm::$METHOD) | ||
| } | ||
| }; | ||
| } | ||
| define_digest_function!( | ||
| sha224, | ||
| Sha224, | ||
| "computes sha224 hash digest of the given input" | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
These are unused but part of our public API; I don't see a good reason to have them exposed so removed them
|
|
||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)] | ||
| pub enum DigestAlgorithm { | ||
| pub(crate) enum DigestAlgorithm { |
Contributor
Author
There was a problem hiding this comment.
Removed from public API
| } | ||
|
|
||
| /// computes md5 hash digest of the given input | ||
| pub fn md5(args: &[ColumnarValue]) -> Result<ColumnarValue> { |
Contributor
Author
There was a problem hiding this comment.
Removed from public API, also moved to md5 file which is the only place its used
| } | ||
|
|
||
| pub fn digest_process( | ||
| pub(crate) fn digest_process( |
Contributor
Author
There was a problem hiding this comment.
Removed from public API
alamb
approved these changes
Feb 3, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup to me
I suppose we could be nicer and deprecate the functions rather than just straight up removing them. However, given the limited impact if someone hits this on upgrade maybe they can just copy the code over 🤔
Contributor
Author
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Removing dead code and remove functions from public API.
What changes are included in this PR?
See comments.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
Yes, some functions removed from public API, but they likely weren't intended to be in our public API.