Skip to content

Comments

FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports#5477

Open
Kengne-yvana wants to merge 1 commit intoapache:developfrom
Kengne-yvana:FINERACT-2436-client-trends-postgres-fix
Open

FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports#5477
Kengne-yvana wants to merge 1 commit intoapache:developfrom
Kengne-yvana:FINERACT-2436-client-trends-postgres-fix

Conversation

@Kengne-yvana
Copy link
Contributor

…thly Trends Reports

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Kengne-yvana Kengne-yvana changed the title FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Mon… FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports Feb 11, 2026
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from 9f6a434 to 1c40e35 Compare February 12, 2026 09:55
@Kengne-yvana
Copy link
Contributor Author

@IOhacker please i am waiting for a review.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 2 times, most recently from 9703641 to ef25373 Compare February 17, 2026 03:54
Comment on lines 28 to 30
<preConditions onFail="MARK_RAN">
<dbms type="postgresql"/>
</preConditions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Comment on lines 43 to 45
<preConditions onFail="MARK_RAN">
<dbms type="postgresql"/>
</preConditions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@adamsaghy
Copy link
Contributor

@Kengne-yvana Please rebase this PR with latest develop branch.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from ef25373 to e6e0a83 Compare February 17, 2026 12:23
@Kengne-yvana
Copy link
Contributor Author

@adamsaghy done

@adamsaghy
Copy link
Contributor

@Kengne-yvana Please rebase this PR with latest develop branch.

@adamsaghy
Copy link
Contributor

@Kengne-yvana Please rebase this PR with latest develop branch.

Also you might wanna cover this report with a test case! ;)

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 4 times, most recently from 6cfb033 to f48b65e Compare February 20, 2026 16:20
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from f48b65e to 0eb2f20 Compare February 20, 2026 16:25
@Kengne-yvana
Copy link
Contributor Author

@adamsaghy done thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants