Skip to content

Add benchmark test run to the CI #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nssalian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add benchmark test run to the CI #3007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650005c
Add benchmark test run to the CI
nssalian Feb 7, 2026
f4bf277
nit
nssalian Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,32 @@ jobs:
path: .coverage*
include-hidden-files: true

benchmark-test:
Copy link
Contributor

@geruh geruh Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run the benchmarks against main as a baseline in the same job? It would be cool to create a report of all the benchmarks that can be uploaded onto the PR. Maybe we should think of this a bit more.

Copy link
Contributor Author

@nssalian nssalian Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try something and add it in a follow up commit

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-python@v6
with:
python-version: '3.12'
- name: Install UV
uses: astral-sh/setup-uv@v7
with:
enable-cache: true
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos
- name: Install
run: make install
Copy link
Contributor

@geruh geruh Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_partitioned_write currently prints average runtime but has no threshold or assertion. Worth adding a baseline comparison

- name: Run benchmarks
Copy link
Contributor

@geruh geruh Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these files are never got produced

run: make test-benchmark
- name: Upload benchmark results
uses: actions/upload-artifact@v4
with:
name: benchmark-results
path: |
.benchmarks/
benchmark-*.json
if-no-files-found: ignore

integration-coverage-report:
runs-on: ubuntu-latest
needs: [integration-test, integration-test-s3, integration-test-adls, integration-test-gcs]
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ test-gcs: ## Run tests marked with @pytest.mark.gcs
sh ./dev/run-gcs-server.sh
$(TEST_RUNNER) pytest tests/ -m gcs $(PYTEST_ARGS)

test-benchmark: ## Run benchmarks marked with @pytest.mark.benchmark
$(TEST_RUNNER) pytest tests/ -m benchmark $(PYTEST_ARGS)

test-coverage: ## Run all tests with coverage and report
$(MAKE) COVERAGE=1 test test-integration test-s3 test-adls test-gcs
$(MAKE) coverage-report
Expand Down