Add 3C3D IoTConsensusV2 integration tests#17257
Open
Pengzna wants to merge 4 commits intoapache:masterfrom
Open
Add 3C3D IoTConsensusV2 integration tests#17257Pengzna wants to merge 4 commits intoapache:masterfrom
Pengzna wants to merge 4 commits intoapache:masterfrom
Conversation
jt2594838
reviewed
Mar 6, 2026
Comment on lines
+133
to
+134
| LOGGER.info("Sleeping 2 seconds to wait replicate ..."); | ||
| Thread.sleep(1000 * 2); |
Contributor
There was a problem hiding this comment.
This is very unstable in the test environment; it is better to check the data directory of each node to ensure that two nodes have the associated TsFiles.
Comment on lines
+172
to
+173
| leaderNode.stopForcibly(); | ||
| Assert.assertFalse("Leader should be stopped", leaderNode.isAlive()); |
Contributor
There was a problem hiding this comment.
Killing the node may result in losing some unflushed data.
Although you may have called FLUSH previously, the data may not have been synchronized then, so the FLUSH command may not work on the follower.
You should first wait until the unsealed TsFile appears on the follower, and then FLUSH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IT for IoTConsensusV2 on a 3 ConfigNode + 3 DataNode cluster.
Tests:
Implementation details: