First cut at a CoPilot review agent

[zwoop]

No description provided.

[Copilot]

Pull request overview

Adds GitHub Copilot instruction documents to guide automated reviews/contributions, including a general ATS-wide instruction set and a focused set for the header_rewrite plugin + hrw4u toolchain.

Changes:

• Added repository-wide Copilot instructions covering ATS architecture, style, and testing guidance.
• Added a scoped instruction file for plugins/header_rewrite/** and tools/hrw4u/** emphasizing feature synchronization and round-trip workflows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
.github/instructions/HRW.instructions.md	Introduces scoped instructions for header_rewrite/hrw4u development and synchronization guidance.
.github/copilot-instructions.md	Introduces repository-wide Copilot guidance on style, architecture patterns, and testing practices.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bryancall]

1. Contradictory guidance on new/delete

Line 100 was correctly updated per Copilot's suggestion:

Prefer RAII/smart pointers over manual delete where practical; some subsystems legitimately use explicit deletes / delete this

But line 104 still says:

❌ Raw new/delete (use smart pointers)

These contradict each other. Should either remove line 104 or soften it to match (e.g. "Avoid raw new/delete where RAII alternatives exist").

2. Debug logging only mentions DbgPrint(), not Dbg()

Lines 242-250 show only the DbgPrint() pattern. The codebase also uses Dbg(). Worth mentioning both or noting which is preferred for new code.

3. kg_visitor.py listed but unexplained

Line 119 of HRW.instructions.md lists kg_visitor.py - Knowledge graph generation with no context on what it does or when a contributor would touch it. Either add a sentence or drop it.

4. has-prefix example is fictional

Lines 164-206 of HRW.instructions.md walk through adding a has-prefix operator. Nothing says it's hypothetical - a contributor (or Copilot) might go looking for OperatorHasPrefix. Add a note like "Hypothetical example to illustrate the workflow:".

5. Missing generators.py in resource/variable checklist

Line 65 of HRW.instructions.md - the "New resource/variable" checklist doesn't mention generators.py for reverse mappings, while the operator and condition checklists do. Should be consistent.

Overall

Good first cut - content is accurate and will improve Copilot's review quality. The only real issue is #1 (the contradiction). The rest are nits. 👍

[bryancall]

All review items from my initial pass have been addressed in the latest commits. The new/delete contradiction is resolved, Dbg() vs DbgPrint() is documented, kg_visitor.py is explained, the has-prefix example is labeled as hypothetical, and generators.py is now in the resource/variable checklist. LGTM.

[zwoop]

[approve ci debian]

[zwoop]

[approve ci]