feat(metadata): use uri RFC 3986 on PHP8.5#7565
Open
SVillette wants to merge 1 commit intoapi-platform:mainfrom
Open
feat(metadata): use uri RFC 3986 on PHP8.5#7565SVillette wants to merge 1 commit intoapi-platform:mainfrom
SVillette wants to merge 1 commit intoapi-platform:mainfrom
Conversation
SVillette
force-pushed
the
feature-use-rfc3986-uri
branch
2 times, most recently
from
c91971d to
c442327
Compare
Member
|
could you maybe rebase this? |
SVillette
force-pushed
the
feature-use-rfc3986-uri
branch
from
c442327 to
bc53a3b
Compare
Author
|
@soyuka PR is rebased. |
Contributor
|
I feel like this work could be simpler by exposing the require method in a BCHelper class or by using a polyfill like https://github.com/thephpleague/uri-polyfill |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of
parse_url()method by the new rfc 3986 URI API on PHP8.5.cc @soyuka this is the subject we talk about at the SymfonyCon hackday.
Still in draft as it's missing some tests.