-
Notifications
You must be signed in to change notification settings - Fork 624
feat: Use specialized Playwright docker images in templates #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e360ccb
1e4a7ec
5820e07
42a89ef
5dd7346
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # % extends 'main.py' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Closing parenthesis formatting Files: templates/main_playwright_chrome.py, The closing ) is on the same line as the last argument: Consider: )
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
|
||
| # % block import | ||
| from crawlee.crawlers import PlaywrightCrawler | ||
| # % endblock | ||
|
|
||
| # % block instantiation | ||
| crawler = PlaywrightCrawler( | ||
| request_handler=router, | ||
| headless=True, | ||
| max_requests_per_crawl=10, | ||
| browser_type="chrome", | ||
| {{ self.http_client_instantiation() }} | ||
| ) | ||
| # % endblock | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # % extends 'main.py' | ||
|
|
||
| # % block import | ||
| from crawlee.crawlers import PlaywrightCrawler | ||
| # % endblock | ||
|
|
||
| # % block instantiation | ||
| crawler = PlaywrightCrawler( | ||
| request_handler=router, | ||
| headless=True, | ||
| max_requests_per_crawl=10, | ||
| browser_type="firefox", | ||
| {{ self.http_client_instantiation() }} | ||
| ) | ||
| # % endblock |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # % extends 'main.py' | ||
|
|
||
| # % block import | ||
| from crawlee.crawlers import PlaywrightCrawler | ||
| # % endblock | ||
|
|
||
| # % block instantiation | ||
| crawler = PlaywrightCrawler( | ||
| request_handler=router, | ||
| headless=True, | ||
| max_requests_per_crawl=10, | ||
| browser_type="webkit", | ||
| {{ self.http_client_instantiation() }} | ||
| ) | ||
| # % endblock |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| # % if cookiecutter.crawler_type.startswith('playwright') | ||
| # % include 'routes_playwright.py' | ||
| # % else | ||
| # % include 'routes_%s.py' % cookiecutter.__crawler_type | ||
| # % endif | ||
Pijukatel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Uh oh!
There was an error while loading. Please reload this page.