Skip to content

Comments

test: Fix flaky test_timeout_in_handler#1764

Open
vdusek wants to merge 1 commit intomasterfrom
fix/flaky-test-timeout-in-handler
Open

test: Fix flaky test_timeout_in_handler#1764
vdusek wants to merge 1 commit intomasterfrom
fix/flaky-test-timeout-in-handler

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Feb 24, 2026

Summary

  • Increased non_realtime_system_coefficient from 2 to 10 in test_timeout_in_handler to fix CI flakiness
  • The outer asyncio.timeout(12s) was too tight for slow CI machines (macOS/Windows), causing the crawler run to be cancelled before all 3 retry attempts could complete
  • New timeout of 60s provides sufficient headroom while the test still completes in ~2s locally

Test plan

  • Verified test passes consistently locally (5/5 runs in ~2.1s each)
  • CI passes on macOS/Windows runners

🤖 Generated with Claude Code

The outer asyncio.timeout(12s) was too tight for slow CI machines
(macOS/Windows), causing the test to be cancelled before all retries
could complete. Increased non_realtime_system_coefficient from 2 to 10
(60s timeout) to provide sufficient headroom.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Feb 24, 2026
@vdusek vdusek self-assigned this Feb 24, 2026
@vdusek vdusek requested a review from Pijukatel February 24, 2026 13:39
@github-actions github-actions bot added this to the 135th sprint - Tooling team milestone Feb 24, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.31%. Comparing base (142e4ef) to head (a04c48f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
+ Coverage   92.23%   92.31%   +0.08%     
==========================================
  Files         156      156              
  Lines       10645    10645              
==========================================
+ Hits         9818     9827       +9     
+ Misses        827      818       -9     
Flag Coverage Δ
unit 92.31% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant